Merge pull request #6 from shakacode/allow-unlabeled-command

Allow unlabeled command
shakacode · Jun 18, 2024 · 5d5b35f · 5d5b35f
2 parents 4272ead + b0b18ab
commit 5d5b35f
Show file tree

Hide file tree

Showing 6 changed files with 290 additions and 26 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ ubuntu-latest, macOS-latest, windows-latest ]
+        os: [ ubuntu-latest, macOS-latest ] # windows build is broken, see the note in README
     steps:
       - name: Checkout sources
         uses: actions/checkout@v2
@@ -21,7 +21,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.66.0
+          toolchain: 1.78.0
           override: true
           components: rustfmt, clippy
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # Changelog
 
+### 0.0.6
+- Allow unlabeled command:
+
+```rust
+cmd! {
+    "cargo build",
+    env: Env::empty(),
+    pwd: Loc::root(),
+    msg: "Building a server",
+}
+```
+
 ### 0.0.5
 - Fix non-TLS build.
 

diff --git a/README.md b/README.md
@@ -19,6 +19,9 @@ See [docs.rs/steward](https://docs.rs/steward).
 See [`examples`](./examples).
 
 ## Limitations
+### Windows
+Apparently, Windows build is broken on recent versions of Rust due to [`winapi`](https://github.com/retep998/winapi-rs) being unmaintained. We need to migrate to [`windows-rs`](https://github.com/microsoft/windows-rs), but I don't know anything about Windows, so help is very welcome!
+
 ### Async runtimes
 Tokio only.
 

diff --git a/examples/cli/main.rs b/examples/cli/main.rs
@@ -79,7 +79,7 @@ mod client {
 
     pub fn build() -> Cmd {
         cmd! {
-            exe: "rescript build -with-deps",
+            "rescript build -with-deps",
             env: env(),
             pwd: Loc::client(),
             msg: "Building ReScript client",
@@ -91,7 +91,7 @@ mod client {
             tag: "rescript",
             cmd:
                 cmd! {
-                    exe: "rescript build -w",
+                    "rescript build -w",
                     env: env(),
                     pwd: Loc::client(),
                     msg: "Watching ReScript client",
@@ -105,7 +105,7 @@ mod server {
 
     pub fn build() -> Cmd {
         cmd! {
-            exe: "cargo build --package=server",
+            "cargo build --package=server",
             env: Config::to_env(),
             pwd: Loc::root(),
             msg: "Building Rust server",
@@ -117,7 +117,7 @@ mod server {
             tag: "server",
             cmd:
                 cmd! {
-                    exe: "cargo watch --watch server --exec 'run --package=server --color=always'",
+                    "cargo watch --watch server --exec 'run --package=server --color=always'",
                     env: Config::to_env(),
                     pwd: Loc::root(),
                     msg: "Running reloadable Rust server",