Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:postprocessors/multi_period_averaging.receiver periodically fails #253

Open
lindsayad opened this issue Aug 2, 2024 · 4 comments
Open

test:postprocessors/multi_period_averaging.receiver periodically fails #253

lindsayad opened this issue Aug 2, 2024 · 4 comments
Assignees
@gsgall

Comments

@lindsayad
Copy link
Member

example at https://civet.inl.gov/job/2364929/ for idaholab/moose#27810
@lindsayad
Copy link
Member Author

@gsgall would you want to look at this or know someone who would?

@gsgall
Copy link
Collaborator

gsgall commented Aug 2, 2024

@lindsayad I can take a look at it

@gsgall
Copy link
Collaborator

gsgall commented Aug 2, 2024 •
edited
Loading

I am not sure I understand what the example you provided is showing me about the Zapdos App, the Civet job and moose issue don't seem to be related to Zapdos, are these changes to MOOSE breaking this Post-processor?

@lindsayad
Copy link
Member Author

No, I think that the test is just brittle. Sometimes it passes and sometimes it doesn't

gsgall added a commit to gsgall/zapdos that referenced this issue Aug 4, 2024
@gsgall
Adding invalid param checking for some of the periodic objects
df9b9b7 
Addresses shannon-lab#253
@gsgall gsgall mentioned this issue Aug 4, 2024
Merged
gsgall added a commit to gsgall/zapdos that referenced this issue Aug 6, 2024
@gsgall
Changing types to help with comparison of counters
644c527 
addresses shannon-lab#253
gsgall added a commit to gsgall/zapdos that referenced this issue Aug 6, 2024
@gsgall
Changing types to help with comparison of counters
797024b 
addresses shannon-lab#253
gsgall added a commit to gsgall/zapdos that referenced this issue Aug 6, 2024
@gsgall
Changing types to help with comparison of counters
1bf578c 
In the MultiPeriodAverager object there was some equality comparison between two floats of variables that should have been unsigned ints. While unable to replicate any reported failures I believe the issue was that on some of the testing machines this equality was never satisfied due to floating point equality comparison.

addresses shannon-lab#253
@gsgall gsgall mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsgall gsgall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @gsgall