Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portals swapper overstating protocol fee in trade modal #7651

Closed
2 tasks done
MBMaria opened this issue Aug 29, 2024 · 0 comments · Fixed by #7661
Closed
2 tasks done

Portals swapper overstating protocol fee in trade modal #7651

MBMaria opened this issue Aug 29, 2024 · 0 comments · Fixed by #7661
Assignees
@gomesalexandre
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Aug 29, 2024

Overview

When viewing the confirm and trade details in the trade modal, the Portals swapper grossly overstates the Protocol Fee.

References and additional details

image
https://jam.dev/c/0f5e6f64-7647-4123-b822-15d5ef5c387c

Acceptance Criteria

Should display accurate protocol fee

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Aug 29, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Aug 29, 2024
@gomesalexandre gomesalexandre mentioned this issue Aug 30, 2024
Merged
1 task
@gomesalexandre gomesalexandre moved this from Up next / groomed to In review in ShapeShift Dashboard Aug 30, 2024
@gomesalexandre gomesalexandre self-assigned this Aug 30, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: portals fees denominated in wrong asset shapeshift/web
2 participants
@gomesalexandre @MBMaria