Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portals validating fee asset balance at quote time since we don't do it at rate time #8268

Closed
0xean opened this issue Dec 4, 2024 · 0 comments · Fixed by #8305
Closed

portals validating fee asset balance at quote time since we don't do it at rate time #8268

0xean opened this issue Dec 4, 2024 · 0 comments · Fixed by #8305
Assignees
@gomesalexandre
Labels
bug Something isn't working

Comments

@0xean
Copy link
Contributor

0xean commented Dec 4, 2024

  • add additional validations to portal at quote time to ensure that we have enough fee asset balance to execute the trade

currently we cannot do this with portals at rate generation time and we don't enforce it later in the flow.
@0xean 0xean added the bug Something isn't working label Dec 4, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Dec 4, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 6, 2024
@gomesalexandre gomesalexandre moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 6, 2024
@gomesalexandre gomesalexandre mentioned this issue Dec 6, 2024
Merged
1 task
@gomesalexandre gomesalexandre moved this from In progress to In review in ShapeShift Dashboard Dec 6, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle not/enough fee asset balance for network fees at final trade quote time shapeshift/web
2 participants
@0xean @gomesalexandre