Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve protocol fees row UI #8302

Open
gomesalexandre opened this issue Dec 6, 2024 · 1 comment
Open

Improve protocol fees row UI #8302

gomesalexandre opened this issue Dec 6, 2024 · 1 comment
Labels
needs product Requires product input before bounty

Comments

@gomesalexandre
Copy link
Contributor

Overview

Spotted while testing #8267

image

As it currently stands, the protocol fees row just shows a dumb list of fees denominated in assets. While it "technically works", there are two issues with this:

  • First of all, we have the notion of payable and non-payable. Those are not reflected to the user, and they have no idea whether or not they should send additional funds for these or not. i.e what if the fees are in a token they don't have, would the first intuition here be "I don't have any of this token, so I can't proceed with this swap" ?
  • Second, it is not very informative as it stands. Showing crypto only is technically correct data, but as a user, I wouldn't know the current rate of E.G SOL or WBTC to make something out of that data

This PR is to improve things twofolds, by adding some informational bits i.e informing users whether a fee is payable (and hence requires a balance of said token or intricate and also showing the fiat value alongside the crypto one

References and additional details

N/A

Acceptance Criteria

  • Protocol fees fiat value is displayed alongside theyr crypto value
  • Some informational bits are implemented to inform users of non/payable fees (icon and tooltip?)

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@gomesalexandre
Copy link
Contributor Author

Fiat is now displayed so that lives us only with tagging rows with more data for users
Another thing we should do as a quick here is pluralize protocol fees, looks like initial assumption was a single fee and we never pluralized copies
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product Requires product input before bounty
Projects
Status: Backlog
Development

No branches or pull requests

1 participant