Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TOML syntax highlighting for uv.lock #3130

Open
fepegar opened this issue Nov 20, 2024 · 2 comments · May be fixed by #3132
Open

Use TOML syntax highlighting for uv.lock #3130

fepegar opened this issue Nov 20, 2024 · 2 comments · May be fixed by #3132
Labels
feature-request New feature or request

Comments

@fepegar
Copy link

fepegar commented Nov 20, 2024

Hi! Thanks a lot for this very nice tool.

I would like bat to use TOML syntax highlighting for uv.lock files. After 5 minutes of research, I'm guessing Dependabot (somehow! I didn't know this feature) updates the syntax file from https://github.com/jasonwilliams/sublime_toml_highlighting. It seems that uv.lock has already been added there: jasonwilliams/sublime_toml_highlighting@215ad51. Should I expect that change to be reflected here soon? If not, happy to contribute with some guidance.

@fepegar fepegar added the feature-request New feature or request label Nov 20, 2024
@keith-hall
Copy link
Collaborator

Hi, thanks for raising the question. In theory, dependabot should indeed bump this dependency, but we don't have to rely on or wait for dependabot - when we notice something is out of date, we can manually bump the submodule version 🙂
We just need to edit the file which tells it which commit to reference, see for example d5b397f#diff-54c2ccb31bbe99d62eed6e299b202ecafe15e821d2e1ed094e3b6157f7739a88R1

@fepegar fepegar linked a pull request Nov 22, 2024 that will close this issue
@fepegar
Copy link
Author

fepegar commented Nov 22, 2024

Thank you, @keith-hall! I've opened #3132, but the changelog CI is complaining and I'm not sure why.

For reference (and fun trying the GitHub CLI), here's what I used to make the changes and open the PR:

gh repo fork --clone https://github.com/sharkdp/bat
cd bat
git submodule update --init --remote assets/syntaxes/02_Extra/TOML
new_branch="3130-use-toml-for-uv-lock"
git switch --create $new_branch
git commit --all --message "Use TOML syntax highlighting for uv.lock"
git push origin $new_branch
gh pr create \
    --base master \
    --repo sharkdp/bat \
    --head fepegar:$new_branch \
    --title "Use TOML syntax highlighting for uv.lock" \
    --body "Resolves #3130."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants