-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve startup time (regression) #525
Comments
Thanks to the changes in #543 by @GuerricChupin, we've moved a significant step in the right direction:
|
Thanks to the changes in #537 by @irevoire (which are not related to the type checker, but still), we've moved another significant step in the right direction:
|
Thanks to various changes by @rben01 (#559, #569, #578, #579, #585, #597, #598 ), there is another 5% improvement in startup time. For more details, see #579 (comment) (note: the absolute times are not comparable. I measured on different machines). Also, note that some of the measurements above might be underestimating the true performance benefit, since Numbats prelude is growing. For a true comparison, we need to run both versions against the same version of the prelude (typically the older one, as the new one might not be supported on the old interpreter). |
The new type checker from #443 introduced a severe regression in startup times:
./numbat-master -e '1+2'
./numbat-1.12 -e '1+2'
We should look into potential measures to improve this again.
If the constraint checker is the culprit, we might want to look into de-duplication of constraints before attempting to solve them. But it might be something else entirely (e.g. the mutation/traversal/cloning of ASTs during elaboration)
The text was updated successfully, but these errors were encountered: