Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"human" function sometimes does not format full minutes correctly #668

Open
ngollon opened this issue Dec 16, 2024 · 3 comments
Open

"human" function sometimes does not format full minutes correctly #668

ngollon opened this issue Dec 16, 2024 · 3 comments

Comments

@ngollon
Copy link

ngollon commented Dec 16, 2024

The "human" function sometimes does not output the given duration in the shortest possible form.

human(3720 second)
 -> "1 hour + 2 minutes"

which I think is correct, but

human(3840s)
 -> "1 hour + 3 minutes + 60 seconds

which I think should be 1 hour + 4 minutes.

@Goju-Ryu
Copy link
Contributor

I reported this in #622 and have a fix in #661 as a result of reimplementing the human function using mixed units.
Currently that PR is awaiting review, but I think it might be a bit before it is merged due to the holidays and all.

@ngollon
Copy link
Author

ngollon commented Dec 16, 2024

Sorry, I did not find your ticket.
This is indeed a duplicate.

Thanks!

@Goju-Ryu
Copy link
Contributor

No worries, I just wanted to give the context and link it for future reference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ngollon @Goju-Ryu and others