Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save API is a bit unintuitive #15

Open
JeffBezanson opened this issue Aug 15, 2020 · 2 comments
Open

save API is a bit unintuitive #15

JeffBezanson opened this issue Aug 15, 2020 · 2 comments

Comments

@JeffBezanson
Copy link

Really nice package! Just taking a close look at the API.

save is a bit odd to me since it doesn't actually save anything unless the function you pass also calls save. Some possible ideas:

  • Make save(path(file), file.value) the default.
  • Call it foreach instead.
  • Something else?
@shashi
Copy link
Owner

shashi commented Aug 15, 2020

Call it foreach instead.

I like this the most!

@shashi
Copy link
Owner

shashi commented Aug 15, 2020

But then save also creates the right paths with mkpath before allowing you to write to that path...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants