Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getindex not working all the way #42

Open
Moelf opened this issue Jan 23, 2021 · 1 comment
Open

getindex not working all the way #42

Moelf opened this issue Jan 23, 2021 · 1 comment

Comments

@Moelf
Copy link

Moelf commented Jan 23, 2021 •
edited
Loading

tree[1] or similar with explicit Int works as defined by:

FileTrees.jl/src/datastructure.jl

Line 185 in 43d7baa

Base.getindex(tree::FileTree, i::Int) = tree.children[i]

but tree[end] doesn't work, nor does tree[1:10]. I think we should delegate all of these to tree.children
@shashi
Copy link
Owner

shashi commented Feb 9, 2021

Good point. Would consider a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shashi @Moelf