Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharp Mossy Cormorant - Typo in require() in setReserve() #79

Closed
sherlock-admin3 opened this issue Oct 31, 2024 · 1 comment
Closed
Labels
Low/Info A Low/Info severity issue. Non-Reward This issue will not receive a payout Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed

Comments

@sherlock-admin3
Copy link

Sharp Mossy Cormorant

Low/Info

Typo in require() in setReserve()

Summary

require(address(_reserve) != address(0), "Reserve address must be set"); at BancorExchangeProvider.sol#L168 should be:

require(_reserve != address(0), "Reserve address must be set");

Mitigation

@sherlock-admin3 sherlock-admin3 added Low/Info A Low/Info severity issue. Non-Reward This issue will not receive a payout labels Oct 31, 2024
@sherlock-admin2
Copy link
Contributor

The protocol team fixed this issue in the following PRs/commits:
mento-protocol/mento-core#545

@sherlock-admin3 sherlock-admin3 added Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low/Info A Low/Info severity issue. Non-Reward This issue will not receive a payout Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed
Projects
None yet
Development

No branches or pull requests

3 participants