Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of dots arguments at daemons() #156

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Improve handling of dots arguments at daemons() #156

merged 2 commits into from
Sep 16, 2024

Conversation

shikokuchuo
Copy link
Owner

Now drops those of the wrong type rather than error.

This will make it easier for package authors to pass in '...' arguments, even if some are unused, in consideration of #137.

@shikokuchuo shikokuchuo self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (1c83562) to head (992fb29).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   99.71%   99.71%   -0.01%     
==========================================
  Files           9        9              
  Lines         700      699       -1     
==========================================
- Hits          698      697       -1     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo merged commit 9a3c180 into main Sep 16, 2024
7 checks passed
@shikokuchuo shikokuchuo deleted the dots branch September 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants