Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed auto scaling group describing to use next_token if reached limit #12

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Fixed auto scaling group describing to use next_token if reached limit #12

merged 2 commits into from
Apr 16, 2018

Conversation

mbloch1986
Copy link
Contributor

  • Fixed ASG Describing to use next_token if ASG Describing hits max_limit

cliffano
cliffano requested changes Apr 16, 2018
View reviewed changes
Copy link
Collaborator

@cliffano cliffano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the lint errors.

@cliffano
Copy link
Collaborator

This is a temporary workaround until we have time to implement #13 .

The downside of using next token is that, for AWS accounts with large number of resources, it would keep navigating through the describe pages result, potentially generating a large list in memory.

#13 should be the way to go.

@cliffano cliffano merged commit a63e42a into shinesolutions:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffano cliffano cliffano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbloch1986 @cliffano