Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security issue: outdated cryptography is used #357

Closed
paulmillr opened this issue Dec 15, 2023 · 4 comments
Closed

Security issue: outdated cryptography is used #357

paulmillr opened this issue Dec 15, 2023 · 4 comments

Comments

@paulmillr
Copy link

You're using elliptic, which has long been unmaintained, and has a few cases where it produces invalid outputs, which means in blockchain context "users lose money".

It is advised to replace it with audited @noble/curves.
@shinyoshiaki
Copy link
Owner

Thanks for the advice. I'll try to migration.

@shinyoshiaki shinyoshiaki mentioned this issue Dec 17, 2023
Merged
@shinyoshiaki
Copy link
Owner

done it #358

@paulmillr
Copy link
Author

not done. you didnt remove elliptic

@shinyoshiaki
Copy link
Owner

shinyoshiaki commented Dec 18, 2023 •
edited
Loading

finally #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmillr @shinyoshiaki