Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type to CRs #1408

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add missing type to CRs #1408

merged 1 commit into from
Oct 18, 2023

Conversation

qu1queee
Copy link
Contributor

Changes

Add proper source type to Builds
The type was missing, which should be Git

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@qu1queee
Add proper source type to Builds
f1e3fcb 
The type was missing, which should be Git
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 18, 2023
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 18, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2023
@qu1queee qu1queee removed the request for review from adambkaplan October 18, 2023 12:31
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 18, 2023
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit 2dac976 into shipwright-io:main Oct 18, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qu1queee @SaschaSchwarze0