Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Report release vulnerabilities action #1751

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SaschaSchwarze0
Copy link
Member

Changes

In this PR, I ...

  • split the action which so far only ran a single script into two scripts: the first script downloads the latest release and determines details (tag, branch, go-version), the second script scans for vulnerabilities, checks if a rebuild fixes them and if that is the case triggers a release
  • extend the action so that after the first script it clones the release branch and also calls setup-go again to use the Go version from the release branch
  • reschedule the action to start 15 minutes after the base image build (which usually takes between four and five minutes to complete)
  • assign the created issue to the users listed as approvers in the OWNERS file

I tested the scripts and their commands, but I cannot test the overall action anywhere as I don't have the necessary releases in a fork.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Dec 13, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Dec 13, 2024
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Only one suggestion, otherwise looks good to the extent of my abilities reading bash scripts (which is not great).

Any way to test this beyond "push and pray"?

@@ -4,7 +4,7 @@
name: Report release vulnerabilities
on:
schedule:
- cron: '0 0 * * *'
- cron: '15 3 * * *' # 3:15 am UTC = 15 minutes after base image build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting 1 hour delay. Even if the base image build typically only takes ~5 minutes, there's no real urgency to run this so quickly afterwards.

Suggested change
- cron: '15 3 * * *' # 3:15 am UTC = 15 minutes after base image build
- cron: '0 4 * * *' # 4:00 am UTC = 1 hour minutes after base image build

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Label for when a PR does not need a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants