-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Report release vulnerabilities action #1751
base: main
Are you sure you want to change the base?
Improve Report release vulnerabilities action #1751
Conversation
Signed-off-by: Sascha Schwarze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Only one suggestion, otherwise looks good to the extent of my abilities reading bash scripts (which is not great).
Any way to test this beyond "push and pray"?
@@ -4,7 +4,7 @@ | |||
name: Report release vulnerabilities | |||
on: | |||
schedule: | |||
- cron: '0 0 * * *' | |||
- cron: '15 3 * * *' # 3:15 am UTC = 15 minutes after base image build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting 1 hour delay. Even if the base image build typically only takes ~5 minutes, there's no real urgency to run this so quickly afterwards.
- cron: '15 3 * * *' # 3:15 am UTC = 15 minutes after base image build | |
- cron: '0 4 * * *' # 4:00 am UTC = 1 hour minutes after base image build |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
In this PR, I ...
I tested the scripts and their commands, but I cannot test the overall action anywhere as I don't have the necessary releases in a fork.
Submitter Checklist
Release Notes