-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
December 11th, 2023 Community Meeting #180
Comments
|
API change on .spec.source.git.url to required. The k8s sig-architecture documents that a change of a field from required to not and vice versa is considerer incompatible. Though, their documentation mainly talks about API calls (e. g. Any API call (e.g. a structure POSTed to a REST endpoint) that succeeded before your change must succeed after your change.) which means that the relevant part if the JSON/YAML serialized format and not the Go types. With that, I suggest that we change it. BTW, when creating this beta Build: apiVersion: shipwright.io/v1beta1
kind: Build
spec:
source:
git:
cloneSecret: deploy-key
type: Git then the converted Alpha build is: apiVersion: shipwright.io/v1alpha1
kind: Build
spec:
source:
credentials:
name: deploy-key
status:
message: all validations succeeded
reason: Succeeded
registered: "True" Both make no sense and it is probably a bug that we register it as successful. Running this build will run without source step. |
Meeting minutes:
|
The text was updated successfully, but these errors were encountered: