February 5th, 2024 Community Meeting

[qu1queee]

• Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
• Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
• (optional) Paste the image of an animal 😸

[qu1queee]

• Making source.type mandatory in beta . From @apoorvajagtap
• Latest extension of SourceResult with the timestamp field.

[SaschaSchwarze0]

Naming pattern of API imports. Including version vs not including it. My take: after we have the change to beta done, we should do one consilidation and go without version but with api as prefix (which would mean buildapi, pipelineapi etc). Rational:

• It will make version changes mainly a change of the import plus only those code changes where the structure must be changed. This allows to focus on relevant things.
• The api suffix is reasonable because just the package name tends to be used as variable name (build, pipeline).

[SaschaSchwarze0]

Field names in Go types. Our previous rule that the json field name matches the Go field name was not followed here: https://github.com/shipwright-io/build/blob/ea6018ec8ff2e23276d7aa17e92a5762969ec8b0/pkg/apis/build/v1beta1/source.go#L104

[qu1queee]

Meeting minutes:

• On making source.type mandatory. We concur this should be the case. In the future, we could make this something that a mutating webhook could handle(setting the type depending on the source type), changing the proposed behaviour. @qu1queee to file an issue if needed.
• On SourceResult timestamp, part one is delivered. Now we will surface a timestamp result depending on the source type. On the local flavour with the waiter, this is not supported. Part two is to surface the ability to generate such timestamp via the Build/BuildRun API. from @HeavyWombat
• PR for moving controllers and pkgs to BETA is ready, open for reviews.
• On naming pattern API imports(from @SaschaSchwarze0 ), proposal is to avoid using a version but rather a common name, This helps on major changes when reviewing and provides consistency across packages. An edge case would be if there is a need to have different API versions of the same package in the same file imports. @SaschaSchwarze0 to file an issue.
• On field names in Go types, regarding breaking the rule(field name should be the same as json key), see GitSource. From @SaschaSchwarze0 . Consensus is to move this change forward. @SaschaSchwarze0 to file an issue.
• On CNCF application ( from @adambkaplan ), to slightly modify one of the paragraphs. Besides this, we can move on with the application.
• From @apoorvajagtap , any plans on providing support for Strategies in the SHP CLI? It seems this was a gap, but it can initially be supported for listing and deleting operations. Providing a full CLI support for Strategies, is something we should revisit in detail. Main pain point is to require additional tools (e.g. kubectl) when working with shp cli. @qu1queee to file an issue for delete/create operations.