Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing deployment configs in YAMLs #6

Open
qu1queee opened this issue Feb 24, 2022 · 2 comments
Open

Support providing deployment configs in YAMLs #6

qu1queee opened this issue Feb 24, 2022 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Feb 24, 2022

Idea:

This will help to inline ways for installing resources, across shipwright-io.

Context:

In shipwright-io/build we enable users to get a quick installation approach using kubectl apply -f a-nice-yaml-file. We should be supporting this here. So we can continue providing the same experience.

Note: As this one also install via package managers such as helm, we should support that in Build, see shipwright-io/build#356

@qu1queee qu1queee added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 24, 2022
@otaviof
Copy link
Member

otaviof commented Mar 1, 2022

For the record, we can use helm to render all the installation resources in a single file, as per:

image/Makefile

Lines 129 to 132 in c65cf8f

helm template \
--namespace="$(NAMESPACE)" \
--set="image=ko://github.com/shipwright-io/image/cmd/imgctrl" \
./chart | \

We should reuse helm output to generate the "single file" release too.

@ricardomaraschini
Copy link
Contributor

This is being address in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants