Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardset loading error messages are uninformative. #412

Open
Alucard648 opened this issue Nov 6, 2024 · 4 comments
Open

Cardset loading error messages are uninformative. #412

Alucard648 opened this issue Nov 6, 2024 · 4 comments

Comments

@Alucard648
Copy link

I find that cardset loading error messages, usually caused by either failure to load image file, or bad config, are quite uninformative, oftenly leaving cardset maker clueless about what he did wrong.
error
And that is generic message for all cardset loading errors.

@joeraz
Copy link
Collaborator

joeraz commented Nov 7, 2024

Can you provide a couple sample cardsets that would trigger this error?

@Alucard648
Copy link
Author

Just try to remove an image from cardset and try to reload it in PySol. You get the same message, regardless what file was not found.

@joeraz
Copy link
Collaborator

joeraz commented Nov 9, 2024

The error wasn't being caught, so I added an error check, which leads to the message that should be displayed.

Though I should probably set it up so a cardset with a missing required card image just doesn't get recognized.

@Alucard648
Copy link
Author

I think, attempt to load cardset with missing image file should output error message like "Failed to find file ####" so cardset maker can correct this by putting in necessary file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants