From 913ceeb437b99c6dc22f8d2fb28866f4383e21b9 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Tue, 17 Sep 2024 07:30:42 +0300
Subject: [PATCH] update action/upload-artifact to @v4

Previous versions were deprecated
---
 .github/workflows/windows-x64.yml                | 10 ++++++----
 .github/workflows/windows-x86.yml                | 16 +++++++++-------
 .../translate-travis.yml-to-github-actions.py    |  7 +++++--
 3 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/windows-x64.yml b/.github/workflows/windows-x64.yml
index f7240ae25..ccc369c70 100644
--- a/.github/workflows/windows-x64.yml
+++ b/.github/workflows/windows-x64.yml
@@ -208,13 +208,15 @@ jobs:
 
                 '
             shell: cmd
-        -   name: upload build artifacts - Freecell Solver Win64 Package
-            uses: actions/upload-artifact@v2
+        -   name: upload-build-artifacts-Freecell Solver Win64 Package-${{ matrix.runs-on
+                }}
+            uses: actions/upload-artifact@v4
             with:
                 name: Freecell Solver Win64 Package
                 path: fc-solve\pkg-build-win64\freecell-solver-*-win64.exe
-        -   name: upload build artifacts - Freecell Solver Win64 MSI Package
-            uses: actions/upload-artifact@v2
+        -   name: upload-build-artifacts-Freecell Solver Win64 MSI Package-${{ matrix.runs-on
+                }}
+            uses: actions/upload-artifact@v4
             with:
                 name: Freecell Solver Win64 MSI Package
                 path: fc-solve\pkg-build-win64\freecell-solver-*-win64.msi
diff --git a/.github/workflows/windows-x86.yml b/.github/workflows/windows-x86.yml
index c5313964e..16758527d 100644
--- a/.github/workflows/windows-x86.yml
+++ b/.github/workflows/windows-x86.yml
@@ -214,19 +214,21 @@ jobs:
 
                 '
             shell: cmd
-        -   name: upload build artifacts - Freecell Solver Zip Distribution for PySol
-                FC
-            uses: actions/upload-artifact@v2
+        -   name: upload-build-artifacts-Freecell Solver Zip Distribution for PySol
+                FC-${{ matrix.runs-on }}
+            uses: actions/upload-artifact@v4
             with:
                 name: Freecell Solver Zip Distribution for PySol FC
                 path: fc-solve\pkg-build\fc-solve-for-pysol.zip
-        -   name: upload build artifacts - Freecell Solver Win32 Package
-            uses: actions/upload-artifact@v2
+        -   name: upload-build-artifacts-Freecell Solver Win32 Package-${{ matrix.runs-on
+                }}
+            uses: actions/upload-artifact@v4
             with:
                 name: Freecell Solver Win32 Package
                 path: fc-solve\pkg-build\freecell-solver-*-win32.exe
-        -   name: upload build artifacts - Freecell Solver Win32 MSI Package
-            uses: actions/upload-artifact@v2
+        -   name: upload-build-artifacts-Freecell Solver Win32 MSI Package-${{ matrix.runs-on
+                }}
+            uses: actions/upload-artifact@v4
             with:
                 name: Freecell Solver Win32 MSI Package
                 path: fc-solve\pkg-build\freecell-solver-*-win32.msi
diff --git a/fc-solve/CI-testing/translate-travis.yml-to-github-actions.py b/fc-solve/CI-testing/translate-travis.yml-to-github-actions.py
index 7c96519f6..e67e14393 100644
--- a/fc-solve/CI-testing/translate-travis.yml-to-github-actions.py
+++ b/fc-solve/CI-testing/translate-travis.yml-to-github-actions.py
@@ -228,8 +228,11 @@ def _myfilt(path):
         is32 = ("\\pkg-build\\" in path)
         return (is32 if x86 else (not is32))
     steps += [{
-        'name': "upload build artifacts - " + art['name'],
-        'uses': "actions/upload-artifact@v2",
+        'name': (
+            "upload-build-artifacts-" +
+            art['name'] + "-${{ matrix.runs-on }}"
+        ),
+        'uses': "actions/upload-artifact@v4",
         'with': art
     } for art in data['artifacts'] if _myfilt(art['path'])]
     skel['name'] = ("windows-x86" if x86 else 'windows-x64')