Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong aspect ratio for VLMPlanner screenshot #53

Open
fayeli opened this issue Dec 11, 2024 · 1 comment
Open

Wrong aspect ratio for VLMPlanner screenshot #53

fayeli opened this issue Dec 11, 2024 · 1 comment

Comments

@fayeli
Copy link

fayeli commented Dec 11, 2024

I noticed that VLMPlanner is consistently doing screenshot at a wrong aspect ratio for my secondary monitor
image

My monitor is a 3440 x 1440 ultrawide, so this may be a rare edge case.

ShowUI, on the other hand, is doing the screenshot at the correct aspect ratio. The mouse coordinate calculation seems to be fine for the next step and the VLMPlanner screenshot issue doesn't seem to affect the model action, at least for my particular test case.
image

Anyways, great work Showlab team! I'm really enjoying seeing the development and just logging this minor issue here in case it is useful to you!

@yyyang-2019
Copy link
Collaborator

Hi @fayeli,
Thanks for your feedback! You're right, we actually want the screenshots passed to vlm_planner to be after resized, e.g. to 1920x1080, in order to control the inference time and token usage. We will consider visualize the image before resized (i.e. its original size) in chat interface so that it doesn't confuse the user. Thanks again for your valuable findings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants