Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax for memory allocation #2

Open
shraiysh opened this issue Jan 20, 2019 · 2 comments
Open

Wrong syntax for memory allocation #2

shraiysh opened this issue Jan 20, 2019 · 2 comments
Labels
first-timers-only Welcome all new open-source contributors good first issue Good for newcomers

Comments

@shraiysh
Copy link
Owner

Memory allocation in Assignments 1 and 2A in CS2233 Data Structures is syntactically wrong. The *s inside malloc must be removed.

Also, the submitted version must be checked with the inputs mentioned in the pdf file and Valgrind(memory leak checker for c/c++).

@shraiysh shraiysh added good first issue Good for newcomers first-timers-only Welcome all new open-source contributors labels Jan 20, 2019
@rdipardo
Copy link

rdipardo commented Jan 3, 2020

Namaste!
If this issue is still open, I am almost ready to push the edits you specified.
Regarding the test cases for Assignment 1, all are passing except the 4 four pictured here:

A1_faulty_test_cases_all

Since the program is running perfectly otherwise, I think we can assume the outputs are correct. As you can see, the one below can be verified with a calculator:

A1_faulty_test_case_1
IMG_0274

As I finish the tests for Assignment 1, I am still undecided if:

  • I should alter the above-noted test-cases to reflect the actually returned values, or;
  • I should let the tests fail because they don't match the published specification

Let me know what approach you think is best!
The other three divergent outputs are here below:

A1_faulty_test_case_2
A1_faulty_test_case_3
A1_faulty_test_case_4

@shraiysh
Copy link
Owner Author

shraiysh commented Jan 7, 2020

Hi, @rdipardo Thanks for working on this!!
I think it is better to update the test cases. Please submit a PR whenever you are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Welcome all new open-source contributors good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants