Skip to content

Commit

Permalink
fix(snyk): replace request package with node-fetch in subapp-web
Browse files Browse the repository at this point in the history
  • Loading branch information
shubham2811 committed Jul 19, 2023
2 parents a78130e + 3c36787 commit 3eba58a
Show file tree
Hide file tree
Showing 8 changed files with 41 additions and 54 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,18 @@ jobs:

steps:
- uses: actions/checkout@v3

# with:
# fetch-depth: 0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

# TODO: enable `rush change -v` after rush migration is completed.
# - name: Verify Change Logs
# run: node common/scripts/install-run-rush.js change --verify --target-branch upstream/master
# - name: Verify Change files and fail build if not available
# run: node common/scripts/install-run-rush.js change --verify

- name: Install
run: node common/scripts/install-run-rush.js install

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Publishing is a three step process. When its time to publish packages (as per re
- Review the CHANGELOG.md updates at this point

#### **2. Publish Packages**
- Run `rush publish --include-all --publish`
- Run `rush publish --include-all --publish --apply`
- This will publish all the public packages that have version increased.
- Push the changes as PR to get the `CHANGELOG.md` updated to `master`.

Expand Down

This file was deleted.

38 changes: 9 additions & 29 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions packages/xarc-opt-karma/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
{
"name": "@xarc/opt-karma",
"entries": [
{
"version": "4.0.0",
"tag": "@xarc/opt-karma_v4.0.0",
"date": "Mon, 17 Jul 2023 19:21:10 GMT",
"comments": {
"major": [
{
"comment": "Fix security vulnerabilities - dependencies upgraded"
}
]
}
},
{
"version": "3.0.1",
"tag": "@xarc/opt-karma_v3.0.1",
Expand Down
9 changes: 8 additions & 1 deletion packages/xarc-opt-karma/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Change Log - @xarc/opt-karma

This log was last generated on Thu, 04 May 2023 21:08:31 GMT and should not be manually modified.
This log was last generated on Mon, 17 Jul 2023 19:21:10 GMT and should not be manually modified.

## 4.0.0
Mon, 17 Jul 2023 19:21:10 GMT

### Breaking changes

- Fix security vulnerabilities - dependencies upgraded

## 3.0.1
Thu, 04 May 2023 21:08:31 GMT
Expand Down
6 changes: 1 addition & 5 deletions packages/xarc-opt-karma/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@xarc/opt-karma",
"version": "3.0.1",
"version": "4.0.0",
"description": "Electrode karma addon for unit tests",
"main": "xarc-opt-check.js",
"homepage": "http://www.electrode.io",
Expand All @@ -16,10 +16,6 @@
"plugins",
"lib"
],
"publishConfig": {
"registry": "https://registry.npmjs.com/",
"access": "public"
},
"author": "Electrode (http://www.electrode.io/)",
"contributors": [
"Joel Chen <[email protected]>"
Expand Down
6 changes: 3 additions & 3 deletions rush.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,17 +213,17 @@
* your PR branch, and in this situation "rush change" will also automatically invoke "git fetch"
* to retrieve the latest activity for the remote main branch.
*/
// "url": "https://github.com/microsoft/rush-example",
"url": "https://github.com/electrode-io/electrode",
/**
* The default branch name. This tells "rush change" which remote branch to compare against.
* The default value is "main"
*/
// "defaultBranch": "main",
"defaultBranch": "master",
/**
* The default remote. This tells "rush change" which remote to compare against if the remote URL is
* not set or if a remote matching the provided remote URL is not found.
*/
// "defaultRemote": "origin"
"defaultRemote": "origin"
},

/**
Expand Down

0 comments on commit 3eba58a

Please sign in to comment.