Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: remove dependency on proc_macro_error #1873

Open
1 task done
nicolasauler opened this issue Sep 10, 2024 · 3 comments · May be fixed by #1921
Open
1 task done

[Improvement]: remove dependency on proc_macro_error #1873

nicolasauler opened this issue Sep 10, 2024 · 3 comments · May be fixed by #1921
Assignees
@Aditya-PS-05
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features

Comments

@nicolasauler
Copy link

Describe the improvement

It seems that the proc_macro_error crate is flagged as unmaintained.

That is used on shuttle_codegen.

Is there any way in which we can upgrade from that crate?

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@nicolasauler nicolasauler added S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features labels Sep 10, 2024
@nicolasauler nicolasauler mentioned this issue Sep 10, 2024
Merged
@JuliDi
Copy link

JuliDi commented Sep 23, 2024

Seems like proc-macro-error-2 could be used as a drop-in replacement since it's a fork of the unmaintained original: https://crates.io/crates/proc-macro-error2

@c-git
Copy link

c-git commented Sep 25, 2024

Add the error message from cargo deny so that others can find this issue more easily

ID: RUSTSEC-2024-0370
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0370
    = proc-macro-error's maintainer seems to be unreachable, with no commits for 2 years, no releases pushed for 4 years, and no activity on the GitLab repo or response to email.
      
      proc-macro-error also depends on `syn 1.x`, which may be bringing duplicate dependencies into dependant build trees.
      
      ## Possible Alternative(s)
      
      - [manyhow](https://crates.io/crates/manyhow)
      - [proc-macro-error2](https://crates.io/crates/proc-macro-error2)
      - [proc-macro2-diagnostics](https://github.com/SergioBenitez/proc-macro2-diagnostics)
    = Announcement: https://gitlab.com/CreepySkeleton/proc-macro-error/-/issues/20
    = Solution: No safe upgrade is available!

@jonaro00 jonaro00 added S-Accepted This will be worked on Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue and removed S-Triage Awaiting decision for what to do labels Sep 26, 2024
@Aditya-PS-05
Copy link

@jonaro00 , I would like to work on this issue. Can you assign me this issue?

@Aditya-PS-05 Aditya-PS-05 linked a pull request Nov 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aditya-PS-05 Aditya-PS-05

Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added proc-macro-error2 dependency Aditya-PS-05/shuttle
5 participants
@JuliDi @c-git @jonaro00 @nicolasauler @Aditya-PS-05