fix: 닉네임 정보가 있더라도 이메일이 없으면 회원가입이 완료되지 않는 오류 해결

side-peek · Mar 18, 2024 · fcc1110 · fcc1110
1 parent 91bfc78
commit fcc1110
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/sidepeek_backend_secret b/sidepeek_backend_secret
diff --git a/src/main/java/sixgaezzang/sidepeek/auth/domain/AuthProvider.java b/src/main/java/sixgaezzang/sidepeek/auth/domain/AuthProvider.java
@@ -27,8 +27,6 @@
 @NoArgsConstructor(access = AccessLevel.PROTECTED)
 public class AuthProvider extends BaseTimeEntity {
 
-    public static final Boolean DEFAULT_IS_REGISTRATION_COMPLETE = false;
-
     @Id
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     @Column(name = "id")
@@ -45,16 +43,11 @@ public class AuthProvider extends BaseTimeEntity {
     @Column(name = "provider_id", length = MAX_PROVIDER_ID_LENGTH)
     private String providerId;
 
-    @Column(name = "is_registration_complete", nullable = false, columnDefinition = "TINYINT")
-    private boolean isRegistrationComplete = DEFAULT_IS_REGISTRATION_COMPLETE;
-
     @Builder
-    private AuthProvider(User user, ProviderType providerType, String providerId,
-        Boolean isRegistrationComplete) {
+    private AuthProvider(User user, ProviderType providerType, String providerId) {
         this.user = user;
         this.providerType = providerType;
         this.providerId = providerId;
-        this.isRegistrationComplete = isRegistrationComplete;
     }
 
 }
diff --git a/src/main/java/sixgaezzang/sidepeek/auth/dto/response/SocialLoginResponse.java b/src/main/java/sixgaezzang/sidepeek/auth/dto/response/SocialLoginResponse.java
@@ -15,8 +15,6 @@ public record SocialLoginResponse(
     String refreshToken,
     @Schema(description = "소셜 로그인 타입", example = "GITHUB")
     ProviderType providerType,
-    @Schema(description = "회원가입 완료 여부", example = "true")
-    boolean isRegistrationComplete,
     @Schema(description = "로그인 사용자 정보")
     UserSummary user
 ) {
@@ -26,7 +24,6 @@ public static SocialLoginResponse of(LoginResponse loginResponse, AuthProvider a
             .accessToken(loginResponse.accessToken())
             .refreshToken(loginResponse.refreshToken())
             .providerType(authProvider.getProviderType())
-            .isRegistrationComplete(authProvider.isRegistrationComplete())
             .user(loginResponse.user())
             .build();
     }

diff --git a/src/main/java/sixgaezzang/sidepeek/auth/oauth/service/OAuth2UserServiceImpl.java b/src/main/java/sixgaezzang/sidepeek/auth/oauth/service/OAuth2UserServiceImpl.java
@@ -63,7 +63,6 @@ private AuthProvider createAuthProvider(Map<String, Object> attributes,
             .providerType(providerType)
             .providerId(providerId)
             .user(user)
-            .isRegistrationComplete(user.getEmail() != null && user.getNickname() != null)
             .build();
 
         return authProviderRepository.save(authProvider);