Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

옵션 값이 있는 요청, 응답에서 값이 빈 경우 타입 통일 #161

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Mar 13, 2024

🎫 관련 이슈

Resolves #156

✅ 구현 내용

  • 옵션 값이 있는 요청, 응답에서 값이 빈 경우 타입 통일
    • string: 빈 문자열("")로 통일
    • 배열: 빈 배열([])로 통일
    • 숫자, 객체: null로 통일
    • enum 타입: 문자열로 주고받기 때문에 string 형식과 동일하게 빈 문자열("")
    • 시간(ex. 프로젝트 시작, 끝 기간): null로 통일

💬 코멘트

@Sehee-Lee-01 Sehee-Lee-01 self-assigned this Mar 13, 2024
@Sehee-Lee-01 Sehee-Lee-01 changed the title Refactor/#156 match empty value 옵션 값이 있는 요청, 응답에서 값이 빈 경우 타입 통일 Mar 13, 2024
Copy link

📝 Jacoco Test Coverage

Overall Project 71.4%
Files changed 100% 🍏

File Coverage
SaveProjectRequest.java 100% 🍏
UserProfileResponse.java 100% 🍏
UserSummary.java 100% 🍏
User.java 92.9% 🍏

Copy link
Contributor

@yenzip yenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 ❤️‍🔥

@@ -11,6 +15,7 @@ public record UserSummary(
Long id,

@Schema(description = "소셜 로그인 회원 여부", nullable = true, example = "false")
@JsonInclude(JsonInclude.Include.NON_NULL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오! 이렇게 설정할 수도 있군요! 😮

values (1, '사이드픽👀', '요즘 사이드 플젝 뭐함? 사이드픽 👀', '데브코스 5기 육개짱팀의 좌충우돌 우당탕탕 프로젝트 개발 일대기',
'https://thumbnail-images.sidepeek.com/1.png', 'https://github.com/side-peek', 20, 7,
'2024-01-29 00:00:00', '2024-03-25 00:00:00', 1, '# SidePeek 기능 Markdown');
'2024-01-29 00:00:00', '2024-03-25 00:00:00', 1, '# SidePeek 기능 Markdown', '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으악... 데이터 많은데 고생 많으셨습니다... ❤️

@Sehee-Lee-01 Sehee-Lee-01 merged commit 985c771 into dev Mar 14, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the refactor/#156-match-empty-value branch March 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants