Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

사용하지 않는 fileType 필드 제거 #178

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Mar 15, 2024

🎫 관련 이슈

Resolves #117

✅ 구현 내용

  • 사용하지 않는 fileType 필드 제거
  • V5 sql 설정

💬 코멘트

  • 현재 프로젝트에서 관리하는 파일은 크게 페이지 상단의 오버뷰 이미지기능설명/트러블 슈팅 글 안의 이미지 두 종류인데 그 중에서 오버뷰 이미지는 따로 테이블에서 관리하고 있습니다!
    • 테이블에서 관리하는 이미지가 오버뷰 이미지만 있기 때문에 현재는 file type으로 구분하지 않아도 되어서 구조를 더 단순하게 하고자 현재 상황에 맞추어 제거했습니다!

Copy link

📝 Jacoco Test Coverage

Overall Project 70.97%
Files changed 100% 🍏

File Coverage
File.java 100% 🍏
FileService.java 100% 🍏
ProjectService.java 94.79% 🍏

Copy link

📝 Jacoco Test Coverage

Overall Project 70.97%
Files changed 100% 🍏

File Coverage
File.java 100% 🍏
FileService.java 100% 🍏
ProjectService.java 94.79% 🍏

Copy link
Contributor

@uijin-j uijin-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 간단하고 좋은 것 같습니당! 감사합니다🥰

@Sehee-Lee-01 Sehee-Lee-01 merged commit 46faa77 into dev Mar 15, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the refactor/#117-delete-filetype branch March 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants