Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack 메시지에 요청 url과 메서드 확인할 수 있도록 구현 #211

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Slack 메시지에 요청 url과 메서드 확인할 수 있도록 구현 #211

merged 2 commits into from
Mar 20, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Mar 20, 2024 •
edited
Loading

🎫 관련 이슈

Resolves #211

✅ 구현 내용

  • Slack 메시지에 요청 url과 메서드 확인할 수 있도록 구현

💬 코멘트

image

@Sehee-Lee-01 Sehee-Lee-01 self-assigned this Mar 20, 2024
@Sehee-Lee-01 Sehee-Lee-01 changed the title Feat/#206 get url method at slack Slack 메시지에 요청 url과 메서드 확인할 수 있도록 구현 Mar 20, 2024
@github-actions GitHub Actions
Copy link

📝 Jacoco Test Coverage

Overall Project 67.72% -0.29% ❌
Files changed 15.38% ❌

File Coverage
MediaExceptionHandler.java 7.41% -12.96% ❌
GlobalExceptionHandler.java 1.76% -3.08% ❌
SlackClient.java 0% -6.3% ❌

uijin-j
uijin-j reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@uijin-j uijin-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry 설정해주셔서 너무 감사합니다🙇🏻‍♀️🩵

@Sehee-Lee-01 Sehee-Lee-01 merged commit 654e7fd into dev Mar 20, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the feat/#206-get-url-method-at-slack branch March 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uijin-j uijin-j uijin-j approved these changes

@yenzip yenzip Awaiting requested review from yenzip yenzip is a code owner

Assignees

@Sehee-Lee-01 Sehee-Lee-01

Labels
🚀 더 만들어봤슈 기능 구현 🛠 리팩토링했슈 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sehee-Lee-01 @uijin-j