Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health check 확인용 api 엔드 포인트 추가 #213

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

uijin-j
Copy link
Contributor

@uijin-j uijin-j commented Mar 20, 2024

🎫 관련 이슈

Resolves #212

✅ 구현 내용

  • health check 확인용 api 엔드 포인트 추가

@uijin-j uijin-j added ⚙️ 세팅했슈 환경 세팅 🚨 돌 굴러가유 긴급 리뷰 labels Mar 20, 2024
@uijin-j uijin-j added this to the 3차 스프린트 milestone Mar 20, 2024
@uijin-j uijin-j self-assigned this Mar 20, 2024
Copy link

📝 Jacoco Test Coverage

Overall Project 67.48% -0.04%
Files changed 50%

File Coverage
HealthCheckController.java 50% -50%

@uijin-j uijin-j merged commit 6ce6d1c into dev Mar 20, 2024
2 checks passed
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오옹 신기하네용 응답만 오먄 사버가 켜져있다는 의미이겟네용!!
하나 배워갑니당!!♥
아래 코멘트 달아놓은 것만 확인 부탁드려용!

public class HealthCheckController {

@GetMapping
public ResponseEntity<LoginResponse> healthCheck() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 body는 안담겨서 오는 것인지 궁금합니다!

Copy link
Contributor Author

@uijin-j uijin-j Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넹 로드밸런서가 바디없이 GET 요청만 한다고 하네용!!
그리고 응답이 200 OK로 오면 해당 서버로 요청 가능한 걸로 간주하고 요청을 전달해 준다고 합니당!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants