프로젝트 상세 조회 QueryDSL 적용 및 리팩토링 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
혹시 의진이 커밋이랑 합쳐진 것 같은데 나중에 확인 한 번만 부탁드립니다! |
엇 커밋 기록이 합쳐졌네용..! 해결해보겠습니다..! |
Sehee-Lee-01
approved these changes
Feb 27, 2024
|
|
||
| public final NumberPath<Long> ownerId = createNumber("ownerId", Long.class); | ||
|
|
||
| public final DateTimePath<java.time.LocalDateTime> startDate = createDateTime("startDate", java.time.LocalDateTime.class); |
There was a problem hiding this comment.
요 부분은 예림님 지금 브랜치 제 작업 브랜치에 머지해서 보니 YearMonth로 되어있드라구요!
혹시 몰라서 코멘트만 남겨놓을게유!
저도 YearMonth인 상태로 작업했어요!!
| @@ -42,6 +43,7 @@ public static ProjectResponse from(Project project, List<OverviewImageSummary> o | |||
| .techStacks(techStacks) | |||
| .startDate(YearMonth.from(project.getStartDate())) | |||
| .endDate(YearMonth.from(project.getEndDate())) | |||
| .ownerId(project.getOwnerId()) | |||
There was a problem hiding this comment.
저도 추가해서 제 브랜치에서 conflict 해결했습니다용!! 여기서두 써주셔서 감사합니당!!👍
| import sixgaezzang.sidepeek.users.dto.response.UserSummary; | ||
|
|
||
| @Repository | ||
| public class MemberRepositoryCustomImpl implements MemberRepositoryCustom { |
Comment on lines
+77
to
+78
| LocalDateTime startDate = LocalDateTime.now(); | ||
| LocalDateTime endDate = startDate.plusMonths(3); |
There was a problem hiding this comment.
요 부분도 제가 YearMonth 미리 머지해서 수정햇습니다! 감사합니다ㅠㅠㅠㅠ
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #57
✅ 구현 내용
💬 코멘트
QueryDSL 관련 블로깅을 작성했습니다..! 사이드픽에서 QueryDSL 적용하기까지 여정
확인해보시고 피드백 주실 것이 있다면 언제든 편하게 해주세요!
@Sehee-Lee-01 프로젝트 생성 관련 테스트 할 때, 제가 만든 메서드(
createXXX)를 편하신 대로 변경해서 사용하셔도 됩니다..!