Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/#19/typesetting] 타입 모듈 추가 #20

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

Whoknow77
Copy link
Contributor

@Whoknow77 Whoknow77 commented Feb 14, 2024

#️⃣연관된 이슈

close #19

💡 핵심적으로 구현된 사항

  • 모듈로 타입을 전역으로 설정했습니다.
  • 주석은 고민하다가 따로 달지 않았습니다.
  • troubleshooting 타입은 아직 객체 형식이 주어지지 않아서 그냥 string으로 일단 설정했습니다.

➕ 그 외에 추가적으로 구현된 사항

🤔 테스트,검증 && 고민 사항

📌 PR Comment 작성 시 Prefix for Reviewers

@Whoknow77 Whoknow77 added the Feat 기능 구현 label Feb 14, 2024
@Whoknow77 Whoknow77 added this to the 1차 스프린트 milestone Feb 14, 2024
@Whoknow77 Whoknow77 self-assigned this Feb 14, 2024
@whdgur5717 whdgur5717 requested review from hellosonic-r, whdgur5717 and miloul and removed request for hellosonic-r February 14, 2024 12:16
Copy link
Contributor

@whdgur5717 whdgur5717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.. 이렇게 보니까 어떤 이름으로 내려오는지 확인하기가 더 쉽네요.
딱히 코드에 대한 리뷰는 없는데, 내려오는 데이터 key의 네이밍에 대해서 한번 이야기해봐도 좋을 것 같습니다!

Copy link
Contributor

@wdgWon wdgWon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훈오님 그냥 뚝딱 잘만드시네요 ㄷㄷ;;
고생하셨고 감사합니다~!

@Whoknow77
Copy link
Contributor Author

훈오님 그냥 뚝딱 잘만드시네요 ㄷㄷ;; 고생하셨고 감사합니다~!

엇 아니에요..그냥 타입만 추가한것뿐이에요 ㅠㅠ 감사합니다

@Whoknow77 Whoknow77 merged commit 5dbb7f3 into dev Feb 15, 2024
@Whoknow77 Whoknow77 deleted the feature/#19/TypeSetting branch February 15, 2024 01:21
@Whoknow77 Whoknow77 changed the title [Feat ✏️] 타입 모듈 추가 [feature/#19/TypeSetting] 타입 모듈 추가 Feb 15, 2024
@Whoknow77 Whoknow77 changed the title [feature/#19/TypeSetting] 타입 모듈 추가 [feature/#19/typesetting] 타입 모듈 추가 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

타입 정의
4 participants