Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow variables in config patches #96

Open
smira opened this issue Sep 24, 2021 · 4 comments
Open

allow variables in config patches #96

smira opened this issue Sep 24, 2021 · 4 comments

Comments

@smira
Copy link
Member

smira commented Sep 24, 2021

e.g. we could have used machine name as machine's hostname

alternatively, this could be just a feature enabled in the spec

@dimatha
Copy link

dimatha commented Nov 12, 2021

That would be perfect!

If I understand it right, there is no way as of now to get the machine name from CAPI and set it on the Talos node(s)?

@smira
Copy link
Member Author

smira commented Nov 12, 2021

well, that depends on the infrastructure provider in general - e.g. on AWS VM name will match Machine name, but hostname will be different (driven by AWS cloud controller logic).

on bare-metal (with Sidero) there's no way to push machine name down to the host.

@dimatha
Copy link

dimatha commented Nov 12, 2021

I'm currently on CAPV (vSphere). Sorry, forgot to mention that one

@dimatha
Copy link

dimatha commented Nov 12, 2021

Not sure if that's following Talos approach but I'll leave it here for a reference.
CAPI kubeadm bootstrap: https://cluster-api.sigs.k8s.io/tasks/kubeadm-bootstrap.html
Cloud-init config-data is used to deliver the hostname of the Machine and it can be used with a mixture of shell commands to set the hostname, etc.

Is that something that should go into the Platform config - https://github.com/talos-systems/talos/blob/release-0.13/internal/app/machined/pkg/runtime/v1alpha1/platform/vmware/vmware_amd64.go ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants