-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow variables in config patches #96
Comments
That would be perfect! If I understand it right, there is no way as of now to get the machine name from CAPI and set it on the Talos node(s)? |
well, that depends on the infrastructure provider in general - e.g. on AWS VM name will match Machine name, but hostname will be different (driven by AWS cloud controller logic). on bare-metal (with Sidero) there's no way to push machine name down to the host. |
I'm currently on CAPV (vSphere). Sorry, forgot to mention that one |
Not sure if that's following Talos approach but I'll leave it here for a reference. Is that something that should go into the Platform config - https://github.com/talos-systems/talos/blob/release-0.13/internal/app/machined/pkg/runtime/v1alpha1/platform/vmware/vmware_amd64.go ? |
e.g. we could have used machine name as machine's hostname
alternatively, this could be just a feature enabled in the spec
The text was updated successfully, but these errors were encountered: