[feature] Omni to set node-role.kubernetes.io label

[TimJones]

Problem Description

Omni has MachineSet visible in the UI grouping the nodes in a helpful way, but current Talos config and Kubernetes security restrictions don't allow for easily setting the node-role.kubernetes.io/<role> label.

Currently an operator or priviledged access process is required to do the equivilent of kubectl label node <name> node-role.kubernetes.io/<role>: "".

Omni has the higher privilege required and the equivalent node/group mapping that could be useful for simple quality-of-life feature.

Solution

Omni can use the MachineSet name to assign the node role label in Kubernetes.

i.e.

MachineSet name: storage -> Node label: node-role.kubernetes.io/storage: "Managed by Omni"
MachineSet name: loadbalancer -> Node label: node-role.kubernetes.io/loadbalancer: "Managed by Omni"
MachineSet name: worker -> Node label: node-role.kubernetes.io/worker: "Managed by Omni"

Alternative Solutions

Stick with operator-maintained labels :)

Notes

Could be a toggle-able feature.