From b0e2eb98ef707dec0707c4ee9c99fc38f8be2e59 Mon Sep 17 00:00:00 2001
From: Felix Moessbauer <felix.moessbauer@siemens.com>
Date: Sat, 13 Jul 2024 15:09:14 +0200
Subject: [PATCH] chore: make install paths configurable

The native messaging dirs vary across Linux distributions. By that,
these dirs need to be configurable. This patch adds this logic, as well
as a note about this ambiguity.

closes: #21

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 Makefile  | 46 +++++++++++++++++++++++++++++-----------------
 README.md |  4 ++++
 2 files changed, 33 insertions(+), 17 deletions(-)

diff --git a/Makefile b/Makefile
index 729f5f5..761b0de 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,15 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
+prefix ?= /usr/local
+exec_prefix ?= $(prefix)
+libexecdir ?= $(exec_prefix)/libexec
+# do not prefix with $(prefix) as these dirs are defined by the browsers
+firefox_nm_dir ?= /usr/lib/mozilla/native-messaging-hosts
+chrome_nm_dir ?= /etc/opt/chrome/native-messaging-hosts
+chrome_ext_dir ?= /usr/share/google-chrome/extensions
+chromium_nm_dir ?= /etc/chromium/native-messaging-hosts
+
 ifeq ($(V),1)
 	Q =
 else
@@ -114,28 +123,31 @@ local-install: local-install-firefox local-install-chrome
 
 install:
 	# Host application
-	install -d $(DESTDIR)/usr/local/lib/linux-entra-sso
-	install -m 0755 linux-entra-sso.py $(DESTDIR)/usr/local/lib/linux-entra-sso
+	install -d $(DESTDIR)/$(libexecdir)/linux-entra-sso
+	install -m 0755 linux-entra-sso.py $(DESTDIR)/$(libexecdir)/linux-entra-sso
 	# Firefox
-	install -d $(DESTDIR)/usr/lib/mozilla/native-messaging-hosts
-	install -m 0644 platform/firefox/linux_entra_sso.json $(DESTDIR)/usr/lib/mozilla/native-messaging-hosts
+	install -d $(DESTDIR)/$(firefox_nm_dir)
+	install -m 0644 platform/firefox/linux_entra_sso.json $(DESTDIR)/$(firefox_nm_dir)
+	sed -i 's|/usr/local/lib/|'$(libexecdir)/'|' $(DESTDIR)/$(firefox_nm_dir)/linux_entra_sso.json
 	# Chrome
-	install -d $(DESTDIR)/etc/opt/chrome/native-messaging-hosts
-	install -m 0644 platform/chrome/linux_entra_sso.json $(DESTDIR)/etc/opt/chrome/native-messaging-hosts
-	sed -i '/{extension_id}/d' $(DESTDIR)/etc/opt/chrome/native-messaging-hosts/linux_entra_sso.json
-	install -d $(DESTDIR)/usr/share/google-chrome/extensions
-	install -m 0644 platform/chrome/extension.json $(DESTDIR)/usr/share/google-chrome/extensions/$(CHROME_EXT_ID_SIGNED).json
+	install -d $(DESTDIR)/$(chrome_nm_dir)
+	install -m 0644 platform/chrome/linux_entra_sso.json $(DESTDIR)/$(chrome_nm_dir)
+	sed -i 's|/usr/local/lib/|'$(libexecdir)/'|' $(DESTDIR)/$(chrome_nm_dir)/linux_entra_sso.json
+	sed -i '/{extension_id}/d' $(DESTDIR)/$(chrome_nm_dir)/linux_entra_sso.json
+	install -d $(DESTDIR)/$(chrome_ext_dir)
+	install -m 0644 platform/chrome/extension.json $(DESTDIR)/$(chrome_ext_dir)/$(CHROME_EXT_ID_SIGNED).json
 	# Chromium
-	install -d $(DESTDIR)/etc/chromium/native-messaging-hosts
-	install -m 0644 platform/chrome/linux_entra_sso.json $(DESTDIR)/etc/chromium/native-messaging-hosts
-	sed -i '/{extension_id}/d' $(DESTDIR)/etc/chromium/native-messaging-hosts/linux_entra_sso.json
+	install -d $(DESTDIR)/$(chromium_nm_dir)
+	install -m 0644 platform/chrome/linux_entra_sso.json $(DESTDIR)/$(chromium_nm_dir)
+	sed -i 's|/usr/local/lib/|'$(libexecdir)/'|' $(DESTDIR)/$(chromium_nm_dir)/linux_entra_sso.json
+	sed -i '/{extension_id}/d' $(DESTDIR)/$(chrome_nm_dir)/linux_entra_sso.json
 
 uninstall:
-	rm -rf $(DESTDIR)/usr/local/lib/linux-entra-sso
-	rm -f  $(DESTDIR)/usr/lib/mozilla/native-messaging-hosts/linux_entra_sso.json
-	rm -f  $(DESTDIR)/etc/opt/chrome/native-messaging-hosts/linux_entra_sso.json
-	rm -f  $(DESTDIR)/etc/chromium/native-messaging-hosts/linux_entra_sso.json
-	rm -f  $(DESTDIR)/usr/share/google-chrome/extensions/$(CHROME_EXT_ID_SIGNED).json
+	rm -rf $(DESTDIR)/$(libexecdir)/linux-entra-sso
+	rm -f  $(DESTDIR)/$(firefox_nm_dir)/linux_entra_sso.json
+	rm -f  $(DESTDIR)/$(chrome_nm_dir)/linux_entra_sso.json
+	rm -f  $(DESTDIR)/$(chromium_nm_dir)/linux_entra_sso.json
+	rm -f  $(DESTDIR)/$(chrome_ext_dir)/$(CHROME_EXT_ID_SIGNED).json
 
 local-uninstall-firefox:
 	rm -f ~/.mozilla/native-messaging-hosts/linux_entra_sso.json ~/.mozilla/linux-entra-sso.py
diff --git a/README.md b/README.md
index f6a17fa..b935dab 100644
--- a/README.md
+++ b/README.md
@@ -70,6 +70,10 @@ This makes the host parts available to all users, but will only work with the si
 On Chrome, the extension is registered to be auto-installed when starting the browser.
 On Firefox and Chromium, the users still need to manually install the browser extension from the respective stores.
 
+**Note:** The native messaging dirs vary across Linux distributions.
+The variables `(firefox|chrome|chromium)_nm_dir` and `chrome_ext_dir` need to be set accordingly.
+The provided defaults work on a Debian system. For details, have a look at the Makefile.
+
 ## Usage
 
 No configuration is required. However, you might need to clear all cookies on