Maintenance work #27
Merged
Maintenance work #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apt frontent should not be used in non-interactive jobs. Instead, apt-get shall be used. Signed-off-by: Felix Moessbauer <[email protected]>
By that, the release tag can be set from the outside when building the package, solving issues around shallow CI clones and non-git copies. Signed-off-by: Felix Moessbauer <[email protected]>
With the existing git checkout configuration, the current tag was not correctly detected by the versioning logic in the Makefile. This led to incorrect version numbers of the debian package. Instead, we now explicitly set the RELEASE_TAG to the information we get from GitHub, when building the release package in CI. Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
The native messaging manifest of chrome and chromium contains two allowed extension ids: A placeholder for a local (non-signed) install and the offical extension id (signed version). When installing globally, the placeholder for the local version needs to be removed. Due to a typo in the Makefile, this happened only for chrome, but not for chromium. Reported-by: Dr. Johann Pfefferl <[email protected]> Signed-off-by: Felix Moessbauer <[email protected]>
jan-kiszka
reviewed
Jul 16, 2024
jan-kiszka
reviewed
Jul 16, 2024
jan-kiszka
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just CI and release creation cleanup. No functional changes to any of the extension parts.