Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EoS workchain fails if structure has multiple site's names with the same symbol. #87

Open
bosonie opened this issue Nov 30, 2020 · 0 comments

Comments

@bosonie
Copy link
Member

bosonie commented Nov 30, 2020

The problem is due to the fact that the rescale method (used to change the volume of the structure), also renames the atoms in case multiple site's names are associated to the same symbol.
This results on a structure whose sites do not match the pseudopotentials dictionary.

Let's suppose to have an hydrogen crystal with two sites:

 s.append_atom(position=(0.000, 2.233, 1.754), symbols=['H'])
 s.append_atom(position=(0.000, -1.225, 2.327), symbols=['H'], name="Hbis")

The structure returned by rescale has the volume changed, but also sites:

<Site: kind name 'H' @ 0.000, 2.233, 1.754>
<Site: kind name 'H1' @ 0.000, -1.225, 2.327>

"Hbis" became "H1" because the correct label is lost in the passage between the StructureData and the ase structure inside rescale. However the pseudopotential input dictionary still presents the key "Hbis", leading to an error ValueError: no pseudo available for element H1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant