Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Track job events in job audit table #1664

Merged
merged 4 commits into from
Nov 12, 2024
Merged

rsc: Track job events in job audit table #1664

merged 4 commits into from
Nov 12, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Oct 15, 2024

Events pertaining to a specific job are added to an append only table for long term tracking and auditing. This data is not currently published outside of the database but will eventually replace the queries provided by the job_history table. Once that is done that table may be deleted but until then data integrity is maintained in both locations.

@V-FEXrt V-FEXrt requested a review from colinschmidt October 15, 2024 22:05
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once we start using this in the dashboard we'll want some indexes probably but just waiting until we know exactly what we need is fine.

@@ -13,6 +13,7 @@ mod m20240522_185420_create_job_history;
mod m20240731_152842_create_job_size_proc;
mod m20240731_201632_create_job_blob_timestamp_index;
mod m20240805_163520_create_blob_id_fk_indexes;
mod m20240809_213440_add_job_audit_table;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this timestamp so that is lands at the end now? Or is that totally irrelevant?

@colinschmidt colinschmidt merged commit 7bdeb81 into master Nov 12, 2024
11 checks passed
@colinschmidt colinschmidt deleted the rsc-job-audit branch November 12, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants