Fix potential "infinite recursion" panics in runners #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a couple problems where the proper reporting of an issue got masked by an "Infinite recursion detected" panic, and we verified that it was due to
primJobFinish
/primJobFailFinish
being called before the respectiveprimJobLaunch
/primJobFailLaunch
-- which for all their other benefits is a new risk with v44's flattened runners. Ultimately it would be best to implement an architecture solution for solving this, but in the mean time it's sufficient to patch the existing runners and to keep a careful eye on future code which touches them.