search: adds functionality to remove search suggestion #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comarquet
force-pushed
the
main
branch
4 times, most recently
from
8d7a9f7
to
d6c417f
Compare
sigma67
reviewed
Nov 16, 2024
ytmusicapi/mixins/search.py
Outdated
| @@ -7,6 +7,10 @@ | |||
|
|
|||
|
|
|||
| class SearchMixin(MixinProtocol): | |||
| def __init__(self): | |||
| self._latest_suggestions = None | |||
| self._latest_feedback_tokens = None | |||
There was a problem hiding this comment.
Despite being an instance, we don't store request-specific state in the YTMusic instance between function calls.
The only state in YTMusic relates to authentication/configuration.
Please move the variables into function parameters.
ytmusicapi/mixins/search.py
Outdated
| @@ -295,7 +299,8 @@ def get_search_suggestions(self, query: str, detailed_runs=False) -> Union[list[ | |||
| { | |||
| "text": "d" | |||
| } | |||
| ] | |||
| ], | |||
| "number": 1 | |||
ytmusicapi/mixins/search.py
Outdated
|
|
||
| return search_suggestions | ||
|
|
||
| def remove_search_suggestion(self, number: int) -> bool: |
There was a problem hiding this comment.
Same here, please rename number to index
ytmusicapi/mixins/search.py
Outdated
| print("Failed to remove suggestion") | ||
| """ | ||
| if self._latest_suggestions is None or self._latest_feedback_tokens is None: | ||
| raise ValueError( |
There was a problem hiding this comment.
Please raise YTMusicError or YTMusicUserError as you see fit
|
Hi ! Thank you for your feedback; it’s greatly appreciated. I’ve implemented all the changes you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #497
I modified parse_search_suggestions so that it retrieves the feedbackToken of each suggestion in the search bar and associates it with the number it is displayed when invoking get_search_suggestions, so that the function remove_search_suggestion can be called with the number as parameter to delete the corresponding entry.