Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend getBalance request by adding support for getCommittedAmount parameter #806

Open
ipr0310 opened this issue Apr 14, 2024 · 1 comment
Labels
API Issues related to the Node's API enhancement New feature or request

Comments

@ipr0310
Copy link
Member

ipr0310 commented Apr 14, 2024

Is your feature request related to a problem? Please describe.

Currently, the getAccount request has support for showing commitment balance.

image
Response example:

{
  "balanceNQT": "16143242542062",
  "unconfirmedBalanceNQT": "41616342062",
  "forgedBalanceNQT": "0",
  "guaranteedBalanceNQT": "16143242542062",
  "committedBalanceNQT": "16101626200000"
  // Remaining properties...
}

But the getBalance request does NOT have support for showing commitment balance.

image
Response example:

{
  "balanceNQT": "16143242542062",
  "unconfirmedBalanceNQT": "41616342062",
  "forgedBalanceNQT": "0",
  "guaranteedBalanceNQT": "16143242542062",
  "requestProcessingTime": 1
}

Describe the solution you'd like
The getBalance request must have support for that parameter also!
image

Describe alternatives you've considered
On the mobile wallet, i will be making the full request instead

Additional context
This request is lightweight compared to getAccount it allows any client to make more efficient queries.

@ipr0310 ipr0310 added enhancement New feature or request API Issues related to the Node's API labels Apr 14, 2024
@ohager
Copy link
Member

ohager commented Apr 17, 2024

Will consider this on current iteration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Node's API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants