Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add validators #183

Open
AgeManning opened this issue Jun 13, 2023 · 0 comments
Open

Ability to add validators #183

AgeManning opened this issue Jun 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@AgeManning
Copy link
Member

Users may be adding validators to an already running set.

One typical approach is to use the EF staking cli script which facilitates new deposists. The resulting artifact from this process is an encrypted json file which needs to be imported into a validator client.

Currently users can do this manually via the API or have to shutdown their VC and then import the file.

It would be a significant UX improvement if users could just add them via Siren.

What we would need:
Some button somewhere that allows us to "import" a validator.

The import should have some window that allows a user to either copy and paste a bunch of json (the json file) or select the file from disk, such that we can load it for them.

Users can select to disable this validator if they want.
They will need to enter a password to decrypt the file.
They will need to enter a fee-recipient (which is a valid execution address (we need to validate this).

Once entered, Siren will register the keystore by building the required json (see the below link) and sending to this endpoint:
https://lighthouse-book.sigmaprime.io/api-vc-endpoints.html#post-lighthousevalidatorskeystore

Note, that the json constructed will require

{ 
enable: 
password:
keystore:
}

which Siren can format based on the input.

Once accepted, Siren should then set the fee-recipient using the following endpoint:
https://ethereum.github.io/keymanager-APIs/#/Fee%20Recipient/setFeeRecipient

The pubkey is known from the keystore json. It might be nice to show this pubkey once users enter the json file, to ensure the user knows which validator is being imported.

If the json import fails, we should not set the fee-recipient and display an error. If the fee-recipient call fails, we should alert the user. Potentially allowing the users to set the fee recipient from the dash would be an added bonus and a way they could try again. The fee-recipient is just an execution address.

@AgeManning AgeManning added the enhancement New feature or request label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants