Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] add PyPI GA post #67

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

woodruffw
Copy link
Member

Adds a short post announcing PEP 740 on PyPI, to be coordinated with the PyPI blog and ToB blog posts.

CC @haydentherapper @di

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nits!

Comment on lines 22 to 25
An important piece of the story for attestations on PyPI is
**default enablement**: if a project uses [Trusted Publishing],
simply upgrading to [`pypa/gh-action-pypi-publish`] [v1.11.0] or newer will result
in attestation generation by default, with no changes required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit too much detail for the Sigstore blog? Readers might not know what pypa/gh-action-pypi-publish is. Maybe we can just say "if a project uses Trusted Publishing and the canonical GitHub Action to upload their distribution" or something like that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll make this change in a moment!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL 🙂

content/pypi-attestations-ga.md Outdated Show resolved Hide resolved
content/pypi-attestations-ga.md Outdated Show resolved Hide resolved
content/pypi-attestations-ga.md Outdated Show resolved Hide resolved
woodruffw and others added 3 commits November 13, 2024 13:33
Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review November 13, 2024 22:36
@woodruffw woodruffw requested review from a team as code owners November 13, 2024 22:36
content/pypi-attestations-ga.md Outdated Show resolved Hide resolved
Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@bobcallaway bobcallaway merged commit 5280430 into sigstore:main Nov 14, 2024
2 checks passed
@woodruffw woodruffw deleted the ww/pypi-ga branch November 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants