Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use object pool for DiffPositions JsonArrays #1313

Open
hahn-kev opened this issue Dec 11, 2024 · 0 comments
Open

use object pool for DiffPositions JsonArrays #1313

hahn-kev opened this issue Dec 11, 2024 · 0 comments
Assignees
@hahn-kev
Labels
📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt
Milestone
vNext

Comments

@hahn-kev
Copy link
Collaborator

once #1308 is merged there will be the method DiffPositions which allocates 2 JsonArrays and throws them away once the method is done, this would be a good use case for an object pool (not aspnet only). The pool should make sure to clear the list when it's returned
@hahn-kev hahn-kev self-assigned this Dec 11, 2024
@hahn-kev hahn-kev added this to the vNext milestone Dec 11, 2024
@hahn-kev hahn-kev added the 📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt label Dec 11, 2024
@myieye myieye mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hahn-kev hahn-kev

Labels
📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt
Projects
None yet
Milestone
vNext
Development

No branches or pull requests
1 participant
@hahn-kev