Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to compare PDFs where one or more of the PDFs have cropmarks #994

Open
markpenny opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@markpenny
Copy link
Collaborator

markpenny commented Oct 22, 2024

We need to be able to detect cropmarks and ignore them in either/both of the PDFs when comparing so that it doesn't trip up on changes beyond the edge of the page.

Similarly, there needs to be a way to offset the starting page number to start comparing the two PDFs. This will enable PDFs with intro matter before the main body to be compared, or specific/individual Bible books against a larger publication.

@markpenny markpenny added the enhancement New feature or request label Oct 22, 2024
@davidg-sil
Copy link
Collaborator

This is basically a case of cropping to the crop-marks or masking out page numbers before the comparison. I assume that the right information is in the PDF for the cropmarks, but we'd need to add something, I presume to flag the page number position. Would that be a special comment (assuming PDFs have comments?), or some kind of additional PDF structure (about which I know nothing useful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants