Summary field looked out of place. #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary field wasnt formated correctly https://pasteboard.co/GTFzo8K.png this css will make it look like https://pasteboard.co/GTFzQkq.png
|
There is some relevant discussion at #485 |
|
We should check that this issue still exists with silverstripe/silverstripe-admin#446 merge into core |
|
Now merged |
|
Ok, this PR could still do with being merged for now I think. I still think this issue should be resolved in framework, but we can patch for now anyway. Here's what it looks like for me on SS 4.1 with blog 3.0.x:
@MichaelJJames would you like to rebase this PR? |
MichaelJJames
added a commit
to MichaelJJames/silverstripe-blog
that referenced
this pull request
Apr 5, 2018
|
Let's follow up conversation on #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary field wasn't formatted correctly
This css will make it look like