Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special handling of a closing time of 00:00 #19

Closed
simonpoole opened this issue Nov 16, 2019 · 2 comments
Closed

Special handling of a closing time of 00:00 #19

simonpoole opened this issue Nov 16, 2019 · 2 comments
Labels
question

Comments

@simonpoole
Copy link
Owner

Should this include a closing time of 00:00 as well as 24:00? I've noticed that in a number of nodes and I'm not sure if that is an error in the data, or if this parser isn't handling it properly.

Originally posted by @TannerYoung in #5 (comment)
@simonpoole
Copy link
Owner Author

@TannerYoung can you give an example of the parser not handling this? We do auto-correct say 06:00-00:00 to 06:00-24:00, but that is what is supposed to happen.

PS: pls open a separate issue if you believe you've found an issue as a rule.

@simonpoole simonpoole changed the title Should this include a closing time of 00:00 as well as 24:00? I've noticed that in a number of nodes and I'm not sure if that is an error in the data, or if this parser isn't handling it properly. Special handling of a closing time of 00:00 Nov 16, 2019
@simonpoole
Copy link
Owner Author

Prior to d829f97 a closing time of 00:00 would count as "earlier" than the start time, the commit provides a further flag, which when set to false, stops strict mode from considering this an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonpoole