Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken image reference in the plugins directory #125

Open
simonw opened this issue Nov 20, 2022 · 1 comment
Open

Broken image reference in the plugins directory #125

simonw opened this issue Nov 20, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Nov 20, 2022

https://datasette.io/plugins/datasette-geojson-map

image

That's a an image reference to this URL, which is a 404: https://datasette.io/plugins/img/boston-neighborhoods-map.png

Ideally that would be rewritten to link here instead:

https://raw.githubusercontent.com/eyeseast/datasette-geojson-map/main/img/boston-neighborhoods-map.png
@simonw simonw added the bug Something isn't working label Nov 20, 2022
simonw added a commit to simonw/datasette-geojson-map that referenced this issue Nov 20, 2022
@simonw
Use a full URL to reference the image
3adf5ab 
Refs simonw/datasette.io#125
@simonw simonw mentioned this issue Nov 20, 2022
Merged
@simonw
Copy link
Owner Author

simonw commented Nov 20, 2022

Rather than get datasette.io to try and fix this I've filed a PR to fix in in the source README instead:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw