Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom scrolling element option #153

Open
Alexloof opened this issue Dec 15, 2021 · 6 comments
Open

Custom scrolling element option #153

Alexloof opened this issue Dec 15, 2021 · 6 comments
Labels
question Further information is requested unconfirmed Problem is not confirmed yet

Comments

@Alexloof
Copy link

Is your feature request related to a problem? Please describe.

I would like to enable the "drag-selecting while scrolling" behaviour in my codebase. However, I have issues because my setup is very complex and includes a lot of components. Therefore, my scrolling element can not be the SelectionArea, and by reading in another issue this must be the case to make this behaviour work.

Describe the solution you'd like

The perfect solution for my use-case would be, that I can pass a custom Element as the "scrolling element" to VanillaSelectionArea config.
@Alexloof Alexloof added the feature request New feature requested label Dec 15, 2021
@Alexloof
Copy link
Author

Alexloof commented Sep 8, 2022

@simonwep Do you have an update to this issue? I really need the "drag-selecting while scrolling" feature 🥇

@simonwep
Copy link
Owner

simonwep commented Sep 8, 2022

Hi! Sorry for coming back to this so late, I'll take a look at it this weekend! :)

@Alexloof
Copy link
Author

Alexloof commented Sep 8, 2022 •
edited
Loading

No worries, now I actually got it working. The gotcha was that the className/element provided in boundries must be the scroll element. So if they are not the same it won't work. So for me, this issue is actually solved even though it wasn't super clear how to do it.
However, now I have another issue/feature request. It might be a bigger one and more complicated so I will open a new ticket if that is fine?

@simonwep
Copy link
Owner

simonwep commented Sep 9, 2022

Hey @Alexloof - that'd be cool, I'll leave this one open and, depending on my findings, update the documentation if necessary :) Just make sure to reproduce it on something like codesandbox ^^

@simonwep simonwep added question Further information is requested documentation Dokumentation is inadequate and removed feature request New feature requested labels Sep 9, 2022
@simonwep simonwep removed their assignment Oct 20, 2022
@simonwep simonwep mentioned this issue Jul 30, 2023
Closed
@simonwep simonwep added unconfirmed Problem is not confirmed yet and removed documentation Dokumentation is inadequate labels Jul 30, 2023
@felixfeng33
Copy link

felixfeng33 commented Jul 4, 2024 •
edited
Loading

Hi, first of all, thank you very much for maintaining an excellent library.But now I encounter this issue. After setting the boundaries, the scrolling speed seems to have slowed down, and occasionally it becomes unresponsive.In this minimal example, it doesn’t seem easy to reproduce the scrolling issue, but the noticeable slowdown in speed can be felt.In Plate.js, the stuttering is noticeably apparent.
codesandbox https://codesandbox.io/p/live/4e8ad628-4916-4f54-8bec-4f29346f14b4

@felixfeng33
Copy link

@Alexloof Hi, After setting the boundaries Did you encounter any issues with the scrolling speed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested unconfirmed Problem is not confirmed yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alexloof @simonwep @felixfeng33