New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Events not being triggered on last element deselection #239

Open

carlos-algms wants to merge 1 commit into simonwep:master from carlos-algms:fix-events-not-triggered-on-deselect

carlos-algms commented Nov 22, 2024

Fixes #238

This PR removes an if statement that blocked move and stop events from being triggered because there were no more selected elements.

Steps to reproduce:

select elements by clicking or dragging a selection
unselect and leave only 1 element
click on that last element

Check the stop event containing no stored elements isn't triggered.


          fix: Events not being triggered on last element deselection

b1fde7e

carlos-algms mentioned this pull request

Unselecting the last element doesn't trigger move and stop #238

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet